strategy155
1 Followers · 1 Following
  • Joined on 2025-02-20
Repositories Projects Packages Public Activity Starred Repositories
strategy155 pushed to main at red_alert/nult 2026-01-15 14:37:44 +00:00
a9554f3e5d Initial commit: nult - Ansible deployment toolkit
strategy155 created branch main in red_alert/nult 2026-01-15 14:37:44 +00:00
strategy155 created repository red_alert/nult 2026-01-15 14:37:13 +00:00
strategy155 pushed to master at red_alert/act-runner-gitea 2026-01-10 15:03:50 +00:00
6982bcf372 Initial commit: Ansible playbook for Gitea Act Runner deployment
strategy155 created branch master in red_alert/act-runner-gitea 2026-01-10 15:03:50 +00:00
strategy155 created repository red_alert/act-runner-gitea 2026-01-10 14:44:59 +00:00
strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

again, no docs, no nothing.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

very cryptic, may be split by multiple stages of creation

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

many problems here, enums, constants, no usage of pandas inline operations, etc.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

write a bit better test for this, more constants, more default values. Now super cryptic.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Very bad quality of code. Some good fixes, really, it was much worse. But still long way to go.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

too inline.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

enums enums enumS!

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

is it a goodpattersn thoug'h, maybe we can formalise the dispatching scheme better?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

maybe more enums for things like this one?

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

bloody hell

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

this file probably should be named properly, and if mained.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Horrible naming.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

All the operations like this should be decopupled, the variabels inside should be named properly, the keys in the dicts should be explicit and moved to constants. Along all places.

strategy155 commented on pull request veles/marketTrade#1 2025-12-21 15:55:25 +00:00
refactor/code-style-standardization

Quite a bad naming here.